Skip to content

Support for large RPC messages using data streams#977

Open
1egoman wants to merge 4 commits intomainfrom
rpc-v2-data-streams
Open

Support for large RPC messages using data streams#977
1egoman wants to merge 4 commits intomainfrom
rpc-v2-data-streams

Conversation

@1egoman
Copy link
Copy Markdown

@1egoman 1egoman commented Apr 28, 2026

See this pull request for more info: livekit/client-sdk-js#1832

@pblazej Sent you a slack message about this with some of the context!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

⚠️ This PR does not contain any files in the .changes directory.

@1egoman 1egoman requested a review from pblazej April 28, 2026 21:09
@pblazej
Copy link
Copy Markdown
Contributor

pblazej commented Apr 29, 2026

The general direction looks good, need a deeper review for possible breaking changes, etc.

@1egoman
Copy link
Copy Markdown
Author

1egoman commented Apr 30, 2026

@pblazej @hiroshihorie Two things:

  • I might need some help getting the ci to pass for this. Looking at the test failures, it looks like the test failures differ each time, and in some targets the tests pass fully while others they don't (and the same tests should be running everywhere...) - are the tests flaky?

  • I have run this implementation through the rpc testing app I built which exercises a given RPC v2 implementation through all the test cases and for the cases that are easy to test, it passes fully! 🎉 . So I think this is in a good state to be reviewed at this point.

@1egoman 1egoman marked this pull request as ready for review April 30, 2026 20:06
@1egoman 1egoman requested a review from hiroshihorie April 30, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants