You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR exposes useGridLayout's existing gridLayouts option through the GridLayout component.
Consumers can now pass custom GridLayoutDefinition[] values directly to GridLayout without needing to use useGridLayout themselves.
Changes
add an optional gridLayouts?: GridLayoutDefinition[] prop to GridLayout
forward gridLayouts from GridLayout into useGridLayout
preserve existing behavior when gridLayouts is not provided
Why
useGridLayout already supports custom grid layout definitions, but that flexibility was not available through the higher-level GridLayout component. This change closes that gap and makes layout customization available without dropping down to the hook layer.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR exposes
useGridLayout's existinggridLayoutsoption through theGridLayoutcomponent.Consumers can now pass custom
GridLayoutDefinition[]values directly toGridLayoutwithout needing to useuseGridLayoutthemselves.Changes
gridLayouts?: GridLayoutDefinition[]prop toGridLayoutgridLayoutsfromGridLayoutintouseGridLayoutgridLayoutsis not providedWhy
useGridLayoutalready supports custom grid layout definitions, but that flexibility was not available through the higher-levelGridLayoutcomponent. This change closes that gap and makes layout customization available without dropping down to the hook layer.