Skip to content

fix(react): Restore isIntersecting and unsubscribed on unmount (#1325)#1326

Open
M-Blobby wants to merge 1 commit intolivekit:mainfrom
M-Blobby:main
Open

fix(react): Restore isIntersecting and unsubscribed on unmount (#1325)#1326
M-Blobby wants to merge 1 commit intolivekit:mainfrom
M-Blobby:main

Conversation

@M-Blobby
Copy link
Copy Markdown

@M-Blobby M-Blobby commented Apr 30, 2026

Summary

  • Fix VideoTrack visibility tracking by wiring useIntersectionObserver correctly with intersectionRef
  • Restore reliable intersectionEntry?.isIntersecting updates for manageSubscription
  • Handle GridLayout pagination/unmount case by unsubscribing on tile unmount, since intersection "exit" is not guaranteed there

I hope my analysis is correct and that this contribution will also be helpful to others.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 30, 2026

⚠️ No Changeset found

Latest commit: 5a8e9a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2026

@M-Blobby is attempting to deploy a commit to the LiveKit Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 30, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants