fix(cli): keep commas in --attribute values - #1004
Closed
RaphaelFakhri wants to merge 1 commit into
Closed
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1003
Summary
--attribute KEY=VALUEis a string slice flag. urfave/cli splits slice flag values on commas unless the command setsDisableSliceFlagSeparator. The commands below did not set it, so a value that contains a comma is split into separate pairs:parseKeyValuePairsthen receivestags=aandb, and the result is{"tags": "a", "": "b"}. The value is truncated and a bogus attribute with an empty key is added.This change sets
DisableSliceFlagSeparatoron the commands that read--attribute, following the existing handling of secrets and agent attributes:lk token createand the deprecatedlk create-tokenlk room joinlk perf agent-load-testRepeat the flag to pass more than one attribute.
These commands also accept comma-separated values for
--allow-source(for examplecamera,microphone). Because the separator is now disabled,lk token createsplits those values itself inparseAllowSources.Testing
TestAttributeFlagKeepsCommasInValues, which finds every command in the token, room, and perf trees that defines--attributeand parses--attribute tags=a,b --attribute mode=xwith that command's flags and separator setting.mainand passes with this change.TestParseAllowSourcesfor the comma-separated--allow-sourcevalues.go test ./cmd/lkpasses.