fix(rtc): keep pending read when AudioMixer stream times out - #736
Closed
RaphaelFakhri wants to merge 1 commit into
Closed
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: dc78d58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AudioMixerraces eachiterator.next()againststreamTimeoutMs. On a timeout it moves on, and the next pass callsnext()again. The first read is still pending, so the frame it later resolves with has no consumer and is dropped. Every timeout leaves another abandoned read, so audio that resumes after a silent period loses its first frames.This change stores the pending read per stream and awaits it again on the next pass instead of starting a new one. The entry is cleared when the read settles, when the read rejects, and in
removeStream.Testing
Added
does not drop a frame that arrives after a read timeouttoaudio_mixer.test.ts. It feeds a stream whose first frame arrives after the read timeout and expects both frames to come out of the mixer.[], expected[111, 222]).Command:
pnpm prebuild && npx vitest run src/audio_mixer.test.tsinpackages/livekit-rtc.A patch changeset for
@livekit/rtc-nodeis included.