fix(rtc): leave ChatMessage editTimestamp undefined when unset - #738
Closed
RaphaelFakhri wants to merge 1 commit into
Closed
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 74e4c60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ChatMessage.editTimestampis optional, butRoomchat events and the results ofsendChatMessageandeditChatMessagebuild it withNumber(editTimestamp). For a message that was never edited the protobuf value isundefined, so the result isNaN.This change adds
chatMessageFromProtoinutils.ts. It converts the fields withbigIntToNumber, which keepsundefined, and the three call sites use it.generatedis now also present on the results ofsendChatMessageandeditChatMessage, matching the chat event.Testing
Added two tests for
chatMessageFromProtoinutils.test.ts: one for an unedited message and one for an edited message.Number(...)conversion: 7 passed, 1 failed (editTimestampisNaN).Command:
pnpm prebuild && npx vitest run src/utils.test.tsinpackages/livekit-rtc.A patch changeset for
@livekit/rtc-nodeis included.