Skip to content

Allow setting a list of SIP codecs for SDP.#1530

Open
dennwc wants to merge 1 commit intomainfrom
sip-codecs
Open

Allow setting a list of SIP codecs for SDP.#1530
dennwc wants to merge 1 commit intomainfrom
sip-codecs

Conversation

@dennwc
Copy link
Copy Markdown
Contributor

@dennwc dennwc commented May 2, 2026

No description provided.

@dennwc dennwc requested a review from a team May 2, 2026 19:57
@dennwc dennwc self-assigned this May 2, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 2, 2026

⚠️ No Changeset found

Latest commit: 7485d20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Comment thread protobufs/rpc/sip.proto
google.protobuf.Duration max_call_duration = 24;

livekit.SIPMediaEncryption media_encryption = 28;
livekit.SIPMediaEncryption media_encryption = 28 [deprecated = true];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How widely used is this right now ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just marking it as deprecated so it's easier to update in our codebase. The old parameter will still continue to work as this PR applies it for both forward and backward compatibility.

bool only_listed_codecs = 1;
// List of allowed codecs. If only_listed_codecs is not set, this list is added to default codecs.
repeated SIPCodec codecs = 2;
SIPMediaEncryption encryption = 3;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What else might we potentially add here in the future ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Krisp is an obvious one we should move here, although I'm not sure how it should look like. Krisp shouldn't be a flag as it is right now, it's better if we allow user to pick from multiple noise cancellation (or other) models. But that would be a bigger change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants