Skip to content

Update jupyter-html deps (major) #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
+812 −665
Open

Update jupyter-html deps (major) #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions livekit-rtc/jupyter-html/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@
"react-dom": "^19.2.4"
},
"devDependencies": {
"@eslint/js": "^9.39.3",
"@eslint/js": "^10.0.0",
"@types/react": "^19.2.14",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^4.7.0",
"eslint": "^9.39.3",
"eslint-plugin-react-hooks": "^5.2.0",
"@vitejs/plugin-react": "^6.0.0",
"eslint": "^10.0.0",
"eslint-plugin-react-hooks": "^7.0.0",
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
"eslint-plugin-react-refresh": "^0.5.0",
"globals": "^17.0.0",
"typescript": "~5.9.0",
"typescript": "~7.0.0",
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.

@devin-ai-integration devin-ai-integration Bot Jul 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 TypeScript upgraded to a version the linter does not support, breaking linting

TypeScript is bumped to version 7 (typescript at livekit-rtc/jupyter-html/package.json:28) while the linter package is left unchanged, but that linter only supports TypeScript below 6.1, so the two can no longer work together.
Impact: Running the project's lint step against the code will fail or emit unsupported-version warnings because the installed toolchain does not officially support TypeScript 7.

Unsatisfied peer dependency between typescript and typescript-eslint

typescript-eslint@^8.56.1 is kept unchanged in livekit-rtc/jupyter-html/package.json:29, and its declared peer requirement is typescript: '>=4.8.4 <6.1.0' (see livekit-rtc/jupyter-html/pnpm-lock.yaml:1224-1226). The bump to typescript: ~7.0.0 resolves to typescript@7.0.2 (livekit-rtc/jupyter-html/pnpm-lock.yaml:1228), which is outside that range. The lint script (eslint .) uses typescript-eslint (see livekit-rtc/jupyter-html/eslint.config.js:5,10), so type-aware linting runs against an unsupported TypeScript version. The renovate update bumped TypeScript to a new major without a compatible bump of typescript-eslint.

Prompt for agents 
The devDependency typescript was bumped to ~7.0.0 but typescript-eslint is kept at ^8.56.1, whose peer dependency requires typescript >=4.8.4 <6.1.0 (confirmed in pnpm-lock.yaml). This makes the installed toolchain unsupported and will break the `lint` script that relies on typescript-eslint. Options: (1) hold TypeScript at a version supported by typescript-eslint (e.g. ~5.9.0) until typescript-eslint publishes a release that supports TypeScript 7, or (2) also upgrade typescript-eslint to a version whose peer range includes TypeScript 7. Verify the lock file resolves a typescript-eslint whose typescript peer range includes the chosen TypeScript version.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"typescript-eslint": "^8.56.1",
"vite": "^6.4.1",
"vite": "^8.0.0",

@devin-ai-integration devin-ai-integration Bot Sep 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Published notebook widget keeps old bundle

After these upgrades, Python packages still ship the old notebook bundle because the generated HTML remains unchanged. room_html loads that committed HTML, not the upgraded source.

Learn more

The notebook widget is distributed as a checked-in HTML resource rather than rebuilt when Python packages are created. The build script writes to that resource, while package data includes the committed HTML in distributions. Neither that resource nor the packaging workflow changed, so the dependency upgrades do not reach users of the packaged widget.

Example: A new RTC wheel built from this commit contains the same notebook HTML as a wheel built from the base commit, even though the Vite dependency is now version 8.

Recommended fix: Run pnpm install --frozen-lockfile and pnpm build in the notebook project, then commit the updated generated resource; alternatively, make the Python packaging build it reproducibly.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"vite-plugin-singlefile": "^2.3.0"
}
}
Loading
Loading