-
Notifications
You must be signed in to change notification settings - Fork 168
Advertise client capabilities to SFU #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chenosaurus
wants to merge
12
commits into
main
Choose a base branch
from
dc/feature/client_capability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c043901
adding client capability
chenosaurus 4ddec8e
generated protobuf
github-actions[bot] 7ecee67
add unit test for caps url parsing
chenosaurus 05d238b
Merge branch 'main' into dc/feature/client_capability
chenosaurus 7bd6036
add changeset
chenosaurus 417ffb7
bump protocol to 1.45.6
chenosaurus 51ef15d
generated protobuf
github-actions[bot] f41cd53
comment
chenosaurus fc8f8a4
cargo fmt
chenosaurus aa9f602
Handle new protocol fields in UniFFI
ladvoc 7fd79b2
Initialize new protobuf field
ladvoc f26164d
Merge remote-tracking branch 'origin/main' into dc/feature/client_cap…
ladvoc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| livekit-api: patch | ||
| livekit-uniffi: patch | ||
| --- | ||
|
|
||
| Add advertising of SDK client capabilities - #1022 (@chenosaurus) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A tiny unit test for this branch would be appreciated.