Skip to content

feat(livekit): auto-flag stereo on audio tracks with num_channels == 2 #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(livekit): auto-flag stereo on audio tracks with num_channels == 2 #1023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions livekit/src/room/participant/local_participant.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,26 @@ impl LocalParticipant {
req.audio_features.push(proto::AudioTrackFeature::TfPreconnectBuffer as i32);
}

// Auto-flag stereo on audio tracks whose underlying source declares
// num_channels == 2. Without this, the server treats the track as
// mono and libwebrtc's Opus path downmixes asymmetric stereo to
// mono-duplicated-both-channels (identical content on L and R).
// This matches the JS client SDK's forceStereo+audioFeatures behaviour.
// RtcAudioSource's num_channels() accessor is private (generated via
// enum_dispatch!), so we match the variant directly.
if let LocalTrack::Audio(audio_track) = &track {
use libwebrtc::audio_source::RtcAudioSource;
let is_stereo = match audio_track.rtc_source() {
RtcAudioSource::Native(native) => native.num_channels() == 2,
#[allow(unreachable_patterns)]
_ => false,
};
if is_stereo {
req.audio_features.push(proto::AudioTrackFeature::TfStereo as i32);
req.stereo = true;
}
}

let mut encodings = Vec::default();
match &track {
LocalTrack::Video(video_track) => {
Expand Down
Loading