Conversation
This ensures that we have a keyframe at the beginning of every segment
Member
Author
|
I'm considering whether to only apply this re-encode if the requested segment duration is <5s or something as we only seem to have hit this issue when the customer wanted to go to 3s. |
Member
Author
|
@thomshutt I've changed this to only re-encode when needed as discussed. We check that the source segments start with a key-frame after the normal non-encode segmentation and retry with a re-encode if needed. |
mjh1
changed the title
thomshutt
approved these changes
Nov 25, 2025
Contributor
thomshutt
left a comment
thomshutt
left a comment
There was a problem hiding this comment.
LGTM - we should monitor both how often this runs and also how often we see issues because there were segments with the issue that weren't in the first 4 or last 2 segments
mjh1
force-pushed
the
mh/segmenting
branch
2 times, most recently
from
075223c to
aab4025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we find a source segment that doesn't start with a keyframe then we redo the segmenting with a re-encode to forcefully insert keyframes.