Right click menus#82
Right click menus#823-john-4 wants to merge 6 commits intolloeki:masterfrom StateFarmIns:right-click-menus
Conversation
src/browser/context-menu-template.js
Outdated
There was a problem hiding this comment.
Man, this seems like a lot of duplication just to show keyboard shortcuts. 😦
There was a problem hiding this comment.
Aren't these actually identical?
There was a problem hiding this comment.
I don't see this one on the context menu, and I'm not seeing any functionality out of it. What is it supposed to do?
There was a problem hiding this comment.
Hmmm. Here's what I'm seeing. Once you select a post you can select Comment and it will add the > followed by the selected text in the new entry field.
There was a problem hiding this comment.
Obvious question but did you pull the latest? I just added this commit late yesterday.
There was a problem hiding this comment.
I pulled it at 11pm. :-) I'll figure it out. Probably just a user error.
On Jan 29, 2016 7:51 AM, "3-john-4" notifications@github.com wrote:
In src/browser/context-menu-template.js
#82 (comment)
:
- },
- {
- type: 'separator'
- },
- {
- label: 'Reload',
- accelerator: 'CmdOrCtrl+R',
- click: reload
- },
- {
- type: 'separator'
- },
- {
- label: 'Comment',
- accelerator: 'Shift+CmdOrCtrl+C',
- click: comment
Obvious question but did you pull the latest? I just added this commit
late yesterday.—
Reply to this email directly or view it on GitHub
https://github.com/HackerHappyHour/matterfront/pull/82/files#r51261992.
|
Nitpicks:
Otherwise, 👍 |
4 participants
Added edit capabilities via right click context menu. See https://github.com/StateFarmIns/matterfront/issues/17