This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Closed
Conversation
Contributor
Author
|
@geekytime all of our builds (including production), are failing due to the following error: 1) Overlay shows when connectionState is not `online`:
TypeError: Cannot convert object to primitive valueThis test had to have passed in order for you to commit it initially, so I'm scratching my head as to why this is failing now. The only thing that comes to mind is that something changed within how JSX is rendering the output of the If you have any ideas, I'd love to hear them. |
Owner
|
Regarding the failing test: just had the issue on Travis with #75, but it passes locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update package meta data due to migration to HackerHappyHour