-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Add support for PDF file uploads as context for LLM queries #3638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
infwinston
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andrewwan0131 left some comments!
infwinston
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks more comments
|
@andrewwan0131 @PranavB-11 I resolved the old comments because it is no longer relevant. We can start commenting this new code as it is pretty different from before. The pdfchat is now operational, I will extensively test it and improve it next. Next steps:
|
infwinston
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @CodingWithTim ! left some quick comments
c70f4bb to
f2c4d64
Compare
777aae7 to
06110d2
Compare
|
71 files changed?? 😭😭 |
|
ohhh it was the formatting commit, it added a billion spaces to every file |
This reverts commit 0955a76.
CodingWithTim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewwan0131 @PranavB-11 @yixin-huang1 Great work guys! I only fixed a few small bugs and cleaned up the logics. Everything now works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need to remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was accidentally created when I pushed the Black formatting commit so we reverted the changes.
|
This PR was transfered to internal repo. |
Why are these changes needed?
These changes enable users to upload PDF files as context for LLM queries.
Changes made
Added PDF file handling capabilities:
Modified relevant files:
Checks