feat(bridge): external account webhook + ENG-350 transfer failure reset#373
Open
heyolaniran wants to merge 3 commits into
Open
Conversation
feat: external accounts event triggering this commit initialize the webhook endpoint to register on Bridge to trigger external account link after plaid completion
this commit mark the transfer as failed in our bridge withdrawals collection when something went wrong during the trasfer flow, the user is notified with a popup and on return state, as well for transfer successfully completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /external-accountwebhook handler — fires after Plaid bank-linking completes, persists the linked account to MongoDB sobridgeExternalAccountsqueries return results. Wires up signature verification, replay routing, and idempotency lock.event === "transfer.failed"branch (Bridge sendstransfer.updated.status_transitioned, nottransfer.failed). Failure detection is now purely by terminal state value. Updates test samples and failure cases to use the real event type.bridgeAddExternalAccount,bridgeInitiateWithdrawal,bridgeExternalAccounts, andbridgeWithdrawals.Test plan
bridgeexternalaccounts, querybridgeExternalAccounts— confirmsidresolver and status mappingexternal_account.createdvia/internal/replay— confirms account persisted and idempotency on duplicate eventtransfer.updated.status_transitionedwith a terminal state via/internal/replay— confirms status flips tofailedand push notification dispatchedalready_terminal, no double notification