Skip to content

Theme auto label#2348

Draft
error7404 wants to merge 1 commit into
lnreader:masterfrom
error7404:WIP-autolabel-NovelFire
Draft

Theme auto label#2348
error7404 wants to merge 1 commit into
lnreader:masterfrom
error7404:WIP-autolabel-NovelFire

Conversation

@error7404

Copy link
Copy Markdown
Collaborator

Theme auto label Improvements: a038b10

  • Add detection for Novel Fire like websites
  • Added a check if multiple themes were found

image


- name: Check HotNovelPub Theme
id: check_hotnovelpub
if: always() && steps.check_madara.outputs.madara != 'true' && steps.check_lighnovelwp.outputs.lighnovelwp != 'true'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't removing this still check the other themes, even if it's already determined to be one?

elif [[ "$FICTIONEER" == "true" ]]; then
echo "🏷️ Adding label: Theme: Fictioneer" >> $GITHUB_STEP_SUMMARY
gh issue edit $ISSUE_NUMBER --add-label "Theme: Fictioneer" -R $REPO
if (( MATCH_COUNT > 1 )); then

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could a site have multiple matches?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants