Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
prepare_cmd_args()inbin/awslocalaliased the livesys.argvlist (cmd_args = sys.argv) and theninsert()ed--endpoint-urlinto it. Every call mutated the process's real argv, so a second call stacked a duplicate--endpoint-urlflag (andrun_as_separate_process's latercmd_args[0] = 'aws'rewrite also leaked intosys.argv).Fix
Work on a copy —
cmd_args = list(sys.argv)— so the inserts/rewrites never touchsys.argv. Single-call behavior is identical; repeated calls are now stable.Tests
New
tests/test_awslocal_prepare_cmd_args.py(loadsbin/awslocalviaSourceFileLoaderwith a stubbedlocalstack_client):test_prepare_cmd_args_inserts_endpoint_once— passes before and after.test_prepare_cmd_args_is_repeatable— fails before (second call returns two--endpoint-urlflags), passes after; also assertssys.argvitself stays clean.