update eks docs to include config for the cluster token#543
Open
update eks docs to include config for the cluster token#543
Conversation
blkgrlcto
requested review from
HarshCasper,
cloutierMat,
dfangl,
nik-localstack,
pinzon,
quetzalliwrites and
simonrw
as code owners
|
|
||
| ## Configuring the k3d Cluster Token | ||
|
|
||
| When LocalStack creates a k3d-backed EKS cluster, it starts the k3s server with an explicit cluster token. This token is used to authenticate agent nodes joining the cluster, ensuring consistent behavior across k3d versions and enabling dynamic node registration (for example, when using Karpenter). |
Contributor
There was a problem hiding this comment.
Let's not mention Karpenter in our docs since we don't fully support this yet. Also version compatibility is not very relevant as a pro for this change.
Suggested change
| When LocalStack creates a k3d-backed EKS cluster, it starts the k3s server with an explicit cluster token. This token is used to authenticate agent nodes joining the cluster, ensuring consistent behavior across k3d versions and enabling dynamic node registration (for example, when using Karpenter). | |
| When LocalStack creates a k3d-backed EKS cluster, it starts the k3s server with an explicit cluster token. This token is used to authenticate agent nodes joining the cluster, enabling dynamic node registration. |
| ## Configuring the k3d Cluster Token | ||
|
|
||
| When LocalStack creates a k3d-backed EKS cluster, it starts the k3s server with an explicit cluster token. This token is used to authenticate agent nodes joining the cluster, ensuring consistent behavior across k3d versions and enabling dynamic node registration (for example, when using Karpenter). | ||
| By default, LocalStack uses localstack-k3d-cluster-token as the cluster token. You can override this value using the `EKS_K3D_CLUSTER_TOKEN` configuration variable: |
Contributor
There was a problem hiding this comment.
Suggested change
| By default, LocalStack uses localstack-k3d-cluster-token as the cluster token. You can override this value using the `EKS_K3D_CLUSTER_TOKEN` configuration variable: | |
| By default, LocalStack uses `localstack-k3d-cluster-token` as the cluster token. You can override this value using the `EKS_K3D_CLUSTER_TOKEN` configuration variable: |
Contributor
nik-localstack
left a comment
nik-localstack
left a comment
There was a problem hiding this comment.
The new configuration variable should be added also in https://docs.localstack.cloud/aws/capabilities/config/configuration/#eks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses DOC-133