feat: add reusable review-e2e-test workflow and skill#52
Open
sowmyav27 wants to merge 2 commits intoloft-sh:mainfrom
Open
feat: add reusable review-e2e-test workflow and skill#52sowmyav27 wants to merge 2 commits intoloft-sh:mainfrom
sowmyav27 wants to merge 2 commits intoloft-sh:mainfrom
Conversation
adds a reusable GitHub Actions workflow that runs the review-e2e-test quality checklist (C1-C16) on any PR touching e2e-next/ files. the skill is served from this public repo so callers need no extra secrets. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- add persist-credentials: false to checkout step - pin claude-code-action to commit hash (970cf56) - ignore secrets-outside-env: api key passed via workflow_call Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sydorovdmytro
requested changes
Mar 30, 2026
| @@ -0,0 +1,525 @@ | |||
| --- | |||
Collaborator
There was a problem hiding this comment.
Why not in https://github.com/loft-sh/ai-skills? It can also be used locally to review tests before CI.
Member
There was a problem hiding this comment.
+1, this can be part of the e2e-tdd-workflow plugin and then we install the plugin in the pipeline
Member
There was a problem hiding this comment.
This also helps since the SKILL.md file points to references it won't be able to resolve 😬
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/review-e2e-test/SKILL.md— copy of the checklist fromai-skills(private), served from this public repo so callers need no extra secrets.github/workflows/review-e2e-test.yml— reusable workflow (workflow_call) that installs the skill viacurland runsanthropics/claude-code-action@v1workflow_dispatchtrigger to enable testing on a branch before a real PR exists (Jan's trick)How callers use it
Each target repo (
vcluster,vcluster-pro,loft-enterprise) adds a thin caller:Test plan
mainloft-enterprise) and merge stub tomainworkflow_dispatchfrom a branch with real e2e-next changes to verify inline comments and request-changes behaviourNotes
SKILL.mdmust be manually synced when the skill is updated inloft-sh/ai-skillscurlin the workflow fetches fromloft-sh/github-actions/main— only resolves after this PR is merged🤖 Generated with Claude Code