fix(release): pin the tag goreleaser releases - #2
Closed
sydorovdmytro wants to merge 1 commit into
Closed
Conversation
goreleaser resolves the current tag from `git tag --points-at HEAD --sort=-version:refname`, which ranks v0.0.1-alpha.2 above v0.0.1. With a stable tag on the same commit as its prerelease it rebuilt and republished the prerelease, and the digest step then found no image for the tag being released.
Contributor
Author
|
Superseded by #1, which landed the same GORELEASER_CURRENT_TAG fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.0.1 release run rebuilt and republished v0.0.1-alpha.2 instead, then failed
looking for an image tagged 0.0.1.
Both tags point at the same commit, and goreleaser picks the current tag off
git tag --points-at HEAD --sort=-version:refname— git's version sort ranksv0.0.1-alpha.2 above v0.0.1. Setting GORELEASER_CURRENT_TAG to the tag the run
started on removes the guess.
Test plan
using tags current=v0.0.1-alpha.2GORELEASER_CURRENT_TAG=v0.0.1:using tags current=v0.0.1, binary reports0.0.1