feat: Create Pool view#210
Open
0x-r4bbit wants to merge 2 commits into
Open
Conversation
3esmit
requested changes
Jun 30, 2026
Collaborator
There was a problem hiding this comment.
This should not be commited.
| // create_new now returns the new wallet's BIP39 mnemonic (empty on failure), | ||
| // not an int status code. TODO: surface this seed phrase to the user for | ||
| // backup — it is currently discarded, so the wallet can't be recovered. | ||
| const QString mnemonic = m_logos->logos_execution_zone.create_new(localConfig, localStorage, password); |
Collaborator
There was a problem hiding this comment.
Where is this const being used? It just creates and discards?
Collaborator
Author
There was a problem hiding this comment.
There's a TODO comment right there. But I've now addressed this in #197
Collaborator
There was a problem hiding this comment.
This asks for securing wallet with password, but storage.rs ignores it
Collaborator
Author
There was a problem hiding this comment.
Yes, this is a flaw in LEZ wallet atm. it doesn't encrypt the wallet files. But our UI still asks for a password, so it's a noop atm.
| // Re-open an existing wallet; only show the create modal on first run. | ||
| if (root.backend && root.backend.walletExists) | ||
| logos.watch(root.backend.openExisting(), | ||
| function(ok) { if (!ok) console.warn("openExisting failed") }, |
Collaborator
There was a problem hiding this comment.
As this is a GUI, surface user flow impacting errors as user dialog facing dialogs
3esmit
force-pushed
the
chore/amm-app-lez-module
branch
3 times, most recently
from
295c4ef to
35c2dd7
Compare
0x-r4bbit
force-pushed
the
chore/amm-app-lez-module
branch
2 times, most recently
from
bf72123 to
2b3ecad
Compare
0x-r4bbit
force-pushed
the
feat/amm-pool-creation
branch
from
ffda1ad to
00e595a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Work in progress
Addresses #30