Repository navigation
Simplify journal adapters and persistence bindings - #145
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused Native_widget handler path and its event/capability/version plumbing. Share Capture bindings across the existing iOS and macOS presentations, remove constant Detail import state, and reuse checkpoint and receipt binding loops. Production typed decoding, picker ownership, platform containers, SQL, error handling, finalization and transaction boundaries are preserved.
Validation: focused existing baseline suites passed; the final full source/native-object build and
dune runtest --forcepassed locally (1,117 Alcotest cases plus existing plain test executables). Journal CI run 339 completed successfully on this PR head. Independent read-only review found no proven issue. The same six pre-existing decision-document formatting failures remain; no documentation, protected spec, Dune, dependency or release-script changes are included.Physical iPhone validation is pending: fresh production-source build 1.5877.75 from commit 2d123d9 passed signing/provenance checks and was installed on the connected iPhone 13 as a same-bundle upgrade. The OS launch succeeded and a subsequent PID-filtered query confirmed the new process remained alive. GUI scenarios are blocked by the iPhone Mirroring Mac-login prompt, awaiting user unlock. The artifact uses experimental host-restamped OCaml objects (
cross_abi_validated=false); hardware acceptance is not yet claimed.