Repository navigation
Normalize equivalent protected sync retractions - #147
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An authoritative echo can contain different encrypted envelopes that decrypt to the same title or name. Replaying the resulting retract/add pair produces extra datoms and can reject a locally accepted journal creation even when the final plaintext facts agree.
Match Logseq's
drop-conflicted-encrypted-retractsrule from logseq/logseq at e7e9c97c: within one decrypted transaction, remove ablock/titleorblock/nameretract only when the exact entity-reference/attribute/value key also has an add. Keep adds, ordering, duplicate adds and all other differences. Normalize at the shared decode boundary so authoritative preview and durable replay use the same operations; preserve exact integrity, origin-interval, checkpoint and outbox/receipt checks.Validation:
dune build @all app/native_embed.exe.o, anddune runtest --forcepassed locally: 1,124 Alcotest cases plus existing plain test executables.spec-dev-toolis unavailable in the local environment, so its document check was not run; this PR changes no documentation, protected spec, Dune, dependency or release files. Validation uses synthetic local data. The reported phone incident remains unconfirmed without its field diagnostics; this PR does not claim that incident has been proven resolved.