Repository navigation
Fix Android rejection of pre-wrap text patches - #295
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android's retained-tree validator rejected legal
white-space: "pre-wrap"text patches atomically, including startup snapshots. Acceptpre-wrapin the existing text-flow matrix so Reader can use the shared canonical-text renderer without host-side wire rewriting.This is a validation correction only; Compose rendering and the wire format are unchanged. Unsupported modes and non-string values remain rejected. Documents compatibility in
docs/api-migrations.md.Validation: one retained vocabulary-table regression failed on the pinned baseline, then all 19
LuiStoreTestcases passed;:lui:assembleDebugand:lui:lintDebugpassed locally on the Android child. Real Reader native startup batches and resync snapshot were also accepted by the Kotlin backend. No emulator/UI pass is claimed here.Link to Devin session: https://app.devin.ai/sessions/c47297d38dc34fd181b18f63166e5679
Open in Devin Desktop: https://app.devin.ai/desktop/session/c47297d38dc34fd181b18f63166e5679?variant=devin
Requested by: @tiensonqin