Repository navigation
Fix Apple normalization of integral floating wire properties - #296
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize integral JSON numbers for all 36
FloatValueproperties before retained-wire validation. Swift's decoder can interpretletter-spacing: 2.0as.int(2), causing otherwise valid startup batches to roll back atomically. Property admission, finite/range checks, and rollback semantics are unchanged; booleans and strings remain rejected.Adds one table-driven contract covering integral, decimal, exponent and fractional encodings, plus migration guidance. The original Reader startup bytes fail on the old backend and both batches are accepted after this fix.
Local validation on the macOS child: focused contract 1/1 passed; full suite 211/212 passed. The legacy full-width pin-focus test also fails on the exact old baseline (210/211), so it is not changed here. Reader native/Melange contracts and iOS simulator/device builds passed with the original identical Swift sources. No iOS UI pass is claimed.
Link to Devin session: https://app.devin.ai/sessions/c47297d38dc34fd181b18f63166e5679
Open in Devin Desktop: https://app.devin.ai/desktop/session/c47297d38dc34fd181b18f63166e5679?variant=devin
Requested by: @tiensonqin