Repository navigation
Keep single-line Android placeholders from inflating field height - #297
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Constrain placeholders in single-line Android text controls to one line with ellipsis. Compose's
OutlinedTextField(singleLine = true)does not constrain its custom placeholder: a crowded weighted row can give the field zero width, making the placeholder wrap into a very tall control. Textareas retain their existing multiline behavior andTextOverflow.Clippolicy.Adds one Layoutlib/Paparazzi measurement regression across the six text-control kinds, plus migration guidance. This corrects placeholder height only; it does not make a zero-width field usable or provide responsive Reader chrome.
Local validation on the Android child with identical final Android sources: the measurement regression failed before the fix, then all 20 tests passed;
assembleDebugpassed and lint reported 0 errors / 7 warnings. No emulator/UI pass is claimed.Link to Devin session: https://app.devin.ai/sessions/c47297d38dc34fd181b18f63166e5679
Open in Devin Desktop: https://app.devin.ai/desktop/session/c47297d38dc34fd181b18f63166e5679?variant=devin
Requested by: @tiensonqin