Repository navigation
fix: prefetch table windows and reuse result projections - #122
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
There was a problem hiding this comment.
✅ Devin resolved the finding on a448f3b
Fixed by Devin (1)
- Date-relative query windows stay stale overnight
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep scrolling ahead of deferred result rendering: prefetch up to 64 rows while retaining the 12-row initial snapshot. Mount only the native viewport plus two rows on either side, independently of the cached data window. Display an in-flight reply when it improves current viewport coverage, even if the exact prefetch key moved; preserve graph/generation/input/revision isolation. Experimental whole-viewport column overscan was withdrawn after real iOS recordings exposed excess remount work.
Reuse scope, filtering/sorting and column projections in a bounded session-local cache. Invalidate by immutable database identity and local journal day: independent graph projections may share a transaction number, and relative-date queries can change overnight without graph edits. Window reads still encode only requested rows.
Validation:
dune build @shared/native/runtest— 1250 tests passed. Focused paging/result-view tests, Android JNI/packaging checks, and Android unit/lint checks passed. The overlapping-response regression fails before the fix and passes afterward.12307830.12307830Android profile/x86_64: unchanged 302×9 Table, original viewport and 180ms inputs; no full-body scrolling blank, missing-row region, or newly blank whole column observed. Installed APK/core hashes match the build. Separate cold-open residual: the bottom visible row appears after 7 raw frames, approximately 117ms; horizontal updates remain discrete.12307830iOS Release: three vertical/horizontal pairs and a separate historical R2 replay with the pre-input Row965/Field5–7 viewport matched within 1px. Raw-sample review reported no full-body blank or contiguous missing-row band. Final horizontal smoothness is not established: desktop capture has 150–183ms sampling gaps around H1; these must not be counted as confirmed app stalls or a pass. The approximately matched 300-row case is not a pixel-identical historical replay.Remaining limitations: simulator/emulator evidence, no physical-device claim, no exhaustive row/column boundary coverage, and no independent touch-release/post-stop timing measurement.
CI follow-up
At
a448f3bd, Vendor duniverse, ocaml-core, and WIP passed. Both E2E jobs failed before running the smoke flow:No space left on device)._build/install/mobile_host/lib/ppxlib/ast/ast.ml.The iOS selector follow-up has therefore not yet been exercised by CI. These latest failures have not been dismissed as flaky or pre-existing. Re-running the failed jobs was rejected with
Resource not accessible by integration; rerun and further investigation remain outstanding.Link to Devin session: https://app.devin.ai/sessions/f2fb979c38d945a9a836b086a5132f95
Open in Devin Desktop: https://app.devin.ai/desktop/session/f2fb979c38d945a9a836b086a5132f95?variant=devin
Requested by: @tiensonqin