Repository navigation
Add language selection and live voice transcription on iOS and Android - #146
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
There was a problem hiding this comment.
Devin Review found 2 findings. Devin automatically fixed all 2 findings.
Fixed by Devin (2)
- Activity recreation deletes active recordings — An Activity destruction during capture used to cancel the service and delete its file. Destruction now detaches only the permission request. Recording operations and pending completion live in an Activity-independent session scope, and the restored runtime resumes saving only into the original graph/target. The save/import handoff cannot be interrupted by runtime disposal. Android full build, 84 existing unit tests and lint passed.
- Orphaned recording blocks future recordings — Reworked request ownership so the recreated runtime always observes the pending session, even when another graph (or no graph) is restored. Cancel now reaches the common completion/cleanup path rather than leaving recordingRequest orphaned. Graph identity is checked only when attaching a non-null asset; a mismatched graph reports an error with the retained audio path instead of importing into the wrong graph. Android full build, unit tests and lint passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AVAudioEngine+SpeechAnalyzer, and Android file replay withAudioRecord+ AAC encoding + ML Kit streaming recognition.Validation
swift test).assembleDebugincluding the native core, unit tests (84), andlintDebugpassed.Real microphone transcription, model installation on supported hardware, backgrounding and actual device lock-screen behavior still need device validation. Live iOS transcription requires iOS 26 and a supported device; Android transcription depends on ML Kit's on-device availability. No UI/lock-screen E2E claims are made by the build and unit-test results.
Link to Devin session: https://app.devin.ai/sessions/ed65e199ce3a442a87f5f63e02234d69
Open in Devin Desktop: https://app.devin.ai/desktop/session/ed65e199ce3a442a87f5f63e02234d69?variant=devin
Requested by: @tiensonqin
🟢 Devin fixed all 2 findings · Follow Devin's work