Repository navigation
Update Apple LUI to hide retained native drawer navigation - #147
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the Apple LUI pin to logseq/lui#317. The earlier opacity-only change in #143 compiled but still failed the same
sidebar.yamlclosed-drawer assertion in https://github.com/logseq/mobile/actions/runs/41841650192/job/126615008747.The panel now has a retained UIKit hosting boundary that hides native navigation descendants from accessibility on close, and hides the native view after its animation. Reopening preserves the panel and inherited environment. No smoke assertions, wire props, or OCaml/Android pins change.
Validation: the simulator
Logseqtarget builds against the published revision. A temporary UIKit probe reproduces missing native hiding before the framework change and passes after it; existing drawer runtime checks pass on iOS 26.5/27.0 with pane identity and scroll offsets preserved. Full iOS smoke remains pending CI.Link to Devin session: https://app.devin.ai/sessions/b120e6386fe04bfeadbc460e2d025dab
Open in Devin Desktop: https://app.devin.ai/desktop/session/b120e6386fe04bfeadbc460e2d025dab?variant=devin
Requested by: @tiensonqin
🟢 Devin Review found nothing to fix · View findings