Repository navigation
fix: keep iPad editor chrome on the active route - #148
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a562931873db79f31f479f2937af7289de7b7f85, including the viewport-visibility fix in Refresh Apple virtual row visibility when the viewport changes lui#318 while preserving the current native drawer fix. A transient zero-height viewport previously removed top rows without registering them again when the viewport recovered.Related: logseq/db-test#1505
Verification
LOGSEQ_IOS_ENABLE_TESTING=1 LOGSEQ_OPAM_SWITCH=5.5.0 opam exec --switch=5.5.0 -- scripts/build-mobile-ios-simulator.sh; fetched LUI checkout clean at the committed pin, no local override.python3 scripts/test-swift-ui-suite.py: 111 tests in 14 suites passed.PushedBlockEditorCheck(3 consecutive final-pin runs),PushedBlockSelectionCheck,SearchEditorToolbarCheck,NavigationContentStabilityCheck,MarkdownScrollCheck,IPadFloatingKeyboardCheck, andLUIVirtualListReentryRuntimeCheckon the same iPad simulator.git diff --checkand staged whitespace checks passed.Known pre-existing failure
OutlinerKeyboardStabilityCheckstill detects a 7pt visible-row shift. The original mobile navigation plus the original LUI pin reproduces the same row40 movement (82.5 → 75.5) with content offset unchanged at 1100. This check is not relaxed or marked passing. Earlier indent-guide overflow diagnostics were inconclusive; this PR does not claim to fix that separate transient.The reported physical iPadOS 27.0.1 device was not available; verification above is the native iPad simulator, not a desktop/web substitute.
Final native iPad evidence
Link to Devin session: https://app.devin.ai/sessions/b14d9e9dd8f84b52a9b0493f3deca31e
Open in Devin Desktop: https://app.devin.ai/desktop/session/b14d9e9dd8f84b52a9b0493f3deca31e?variant=devin
Requested by: @tiensonqin
🟢 Devin Review found nothing to fix · View findings