Repository navigation
Fix blank recording Live Activities on the lock screen - #150
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+23
to
+28
| frame = re.search(r"\(frame \(([^)]+)\)\)", entry) | ||
| if frame is None: | ||
| raise AssertionError("The system-rendered activity has no layout frame") | ||
| values = frame[1].replace(";", " ").split() | ||
| if not all(math.isfinite(float(value)) for value in values): | ||
| raise AssertionError(f"Invalid system activity layout: {frame[0]}") |
There was a problem hiding this comment.
🔍 Timer visibility remains untested
validate_render rejects nonfinite frames but accepts zero-sized ones. The check can pass even when the timer occupies no visible space.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording could leave an empty black Live Activity on the lock screen. The timer's
fixedSize()layout produces NaN root widths in WidgetKit's archived renderer, even though an in-process SwiftUI preview renders successfully.Size the running timer with hidden monospaced placeholder text and overlay the live timer. Add a simulator regression check that backgrounds the harness and inspects actual WidgetKit archived frames for the lock-screen card and compact Dynamic Island timer.
Validation: