Skip to content

Update Apple LUI to detach closed drawer accessibility - #152

Merged
tiensonqin merged 3 commits into
mainfrom
devin/1793813452-drawer-detach-pin
Nov 4, 2026
Merged

tiensonqin merged 3 commits into
mainfrom
devin/1793813452-drawer-detach-pin

Conversation

@tiensonqin

@tiensonqin tiensonqin commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Pin Apple LUI to 230783b998ecd1cce3712a1d1404e44ea94915cf from logseq/lui#319. After the close animation, the retained hosting view leaves the window so its virtual accessibility proxies no longer appear in XCTest snapshots. Reopening attaches the same view without replacing the controller or content.

This addresses the unchanged sidebar.yaml failure after closing (assertNotVisible: link.sidebar.graphs). Only the SwiftPM revision and resolved origin hash change; Android, app behavior and test assertions are untouched.

The original four-flow local smoke passed against the identical LUI source (251s), with native controller/view/scroll-view identity preserved across close/reopen. The full simulator app builds with the remote exact pin and no SwiftPM edit override; final committed-pin smoke is being repeated. Hosted iOS CI remains a separate acceptance result. Nonzero scroll and regular-width pinned mode were not exercised.

Sidebar closed after the original regression flow

Link to Devin session: https://app.devin.ai/sessions/b120e6386fe04bfeadbc460e2d025dab
Open in Devin Desktop: https://app.devin.ai/desktop/session/b120e6386fe04bfeadbc460e2d025dab?variant=devin
Requested by: @tiensonqin


🟢 Devin Review found nothing to fix · View findings

Devin Review

@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@tiensonqin
tiensonqin merged commit 5ec719d into main Nov 4, 2026
4 checks passed
@devin-ai-integration

devin-ai-integration Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Final validation is complete; this supersedes the pre-merge description's pending-smoke note.

Hosted CI: mobile fd93761df2c073f227b1d482ed4be8c08858de2e and merged main 5ec719d67056591b950f74ab68b714656796da09 each passed 4/4 checks, including iOS E2E, Android E2E, ocaml-core and Vendor duniverse. No failures or pending checks remain on either mobile commit.

LUI 230783b998ecd1cce3712a1d1404e44ea94915cf from logseq/lui#319 passed Apple tests (overall 13 passed, 2 skipped). Merged LUI 5dedc5823ac0a308cc6df68ab59a3c6a2e893140 has 15 passed, 1 skipped; Apple tests were skipped on that run, not counted as an execution. Both squash-merge trees exactly match their validated source trees.

Local exact-pin acceptance: 4/4 original Maestro smoke flows passed in 165s, exit 0 on mobile fd93761d, using remote LUI 230783b9 as sourceControlCheckout with no edit override. The rebuilt app was explicitly installed; its embedded revision and built/installed executable hashes matched. Original live setup, first close and both swipe directions passed without changing assertions.

Full annotated recording

Final exact-pin sidebar closed

Full smoke recording preview

Exact-pin four-flow smoke

Nonzero scroll and regular-width pinned mode were not exercised. Native controller/view identity was verified on the earlier identical-source candidate, not repeated on the final binary. Microphone/audio behavior was excluded.

Written by Devin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant