Repository navigation
Update Apple LUI to detach closed drawer accessibility - #152
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Final validation is complete; this supersedes the pre-merge description's pending-smoke note. Hosted CI: mobile LUI Local exact-pin acceptance: 4/4 original Maestro smoke flows passed in 165s, exit 0 on mobile Nonzero scroll and regular-width pinned mode were not exercised. Native controller/view identity was verified on the earlier identical-source candidate, not repeated on the final binary. Microphone/audio behavior was excluded. |
Summary
Pin Apple LUI to
230783b998ecd1cce3712a1d1404e44ea94915cffrom logseq/lui#319. After the close animation, the retained hosting view leaves the window so its virtual accessibility proxies no longer appear in XCTest snapshots. Reopening attaches the same view without replacing the controller or content.This addresses the unchanged
sidebar.yamlfailure after closing (assertNotVisible: link.sidebar.graphs). Only the SwiftPM revision and resolved origin hash change; Android, app behavior and test assertions are untouched.The original four-flow local smoke passed against the identical LUI source (251s), with native controller/view/scroll-view identity preserved across close/reopen. The full simulator app builds with the remote exact pin and no SwiftPM edit override; final committed-pin smoke is being repeated. Hosted iOS CI remains a separate acceptance result. Nonzero scroll and regular-width pinned mode were not exercised.
Link to Devin session: https://app.devin.ai/sessions/b120e6386fe04bfeadbc460e2d025dab
Open in Devin Desktop: https://app.devin.ai/desktop/session/b120e6386fe04bfeadbc460e2d025dab?variant=devin
Requested by: @tiensonqin
🟢 Devin Review found nothing to fix · View findings