Open
Make WEBrick test teardown block until the server thread exits#165
Conversation
Co-authored-by: donoghuc <15354214+donoghuc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix flakiness in tests due to WEBrick shutdown sequence
Make WEBrick test teardown block until the server thread exits
Sep 8, 2026
donoghuc
approved these changes
Sep 9, 2026
donoghuc
marked this pull request as ready for review
September 9, 2026 23:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flaky HTTP output specs were starting WEBrick on a background thread and tearing it down asynchronously, which could leave the listener alive between examples and hang retries against a server that had not fully stopped.
Return the WEBrick thread from the shared test helper
start_app_and_waitnow returns both the server instance and the thread runningapp.start!Add a blocking teardown helper
stop_app_and_wait(app, server, server_thread)app.stop!server.shutdownserver_thread.join(30)Update the existing spec call sites
@server_thread