Repository navigation
Fix synchronous callbacks on rejected requests - #86
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
A synchronous callback returning
JSONResponsecurrently crashes when the rate limit is reached. The error isTypeError: 'JSONResponse' object can't be awaited.The shared callback helper now awaits awaitable results and returns other values directly. HTTP and WebSocket dependencies and middleware use it.
make cipasses all 17 tests on Python 3.10 and 3.14 with pyrate-limiter 4.0.2.make buildand the Ruff formatting check pass. Three synchronous callback regressions fail on unchanged upstream. Nine async callback cases pass on both versions.Python 3.9 has an existing dependency mismatch on unchanged upstream. Its locked pyrate-limiter 3.9.0 rejects the
blockingargument before callbacks run. This PR leaves dependency metadata unchanged.