shell: validate default TextView link URLs - #3048
Open
lurenjia534 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When no script
on_link_clickcallback is provided, Shell inheritsgpui-base::TextView's default link handling. HTML and Markdown links can therefore reachApp::open_urlwithout the URL validation already enforced byLink.hrefand the script-facingcx.open_url.Install a Shell-owned default handler that applies the same validation: a parsed HTTP(S) URL with a host. Preserve the existing activation conditions and leave explicit script callbacks unchanged.
This PR only changes default link activation in Shell and adds focused regression tests. Base APIs, image loading, and network capability handling are unchanged.
How to Test
Verified the behavior before and after the fix:
App::open_url. Valid HTTP(S) links still open on left/middle click.on_link_clickcallbacks still receive the original URL without triggering default opening.Both regression tests passed: 36 default-link combinations and 12 callback combinations, covering HTML and Markdown with left, middle, and right mouse buttons. Formatting checks also passed.
Link opening is checked through GPUI's test context; these tests do not launch actual OS URL handlers.
Checklist
cargo runfor story tests related to the changes.