feat: embed GPUI Kit Markdown in a Swift iOS container - #2
Merged
Conversation
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Embed GPUI Kit's Markdown TextView in a Swift-owned UIKit window instead of letting GPUI create the iOS example's window. A child controller renders into
GPUITextView: UIView; native Compact / Expanded controls exercise layout changes. The light English sample puts emphasis, quotes, nested lists, code, tables, and tasks on the first screen.Fix two startup failures exposed by the simulator: supply the UIKit display handle to wgpu 29, and retain the
run_embeddedapplication handle so native callbacks cannot outlive the GPUI app. Synchronize layout and redraw without implicit animations during size changes. Correct the Xcode static-library paths and build directory.Pins GPUI Kit to commit
7d9efcd2069f9eaa6eb3ba6345aac4aa7d87c9f7from longbridge/gpui-kit#3045, so a sibling local checkout is not required. No crates are published.The embedding example supports one GPUI view for the application lifetime; independent destruction and multiple instances are not implemented.
Test Plan
cargo check --manifest-path example/Cargo.toml --target aarch64-apple-ios-simwith the pinned Git dependency.git diff --checkandbash -n example/build.sh.