Repository navigation
feat: ship AUTOSAR delivery consistency checks in v1.19.0 - #48
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e57d7764bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| call = item.get('call') | ||
| context = dict(item) | ||
| context['file'] = call.file if call else item.get('arxml_file', item.get('file', '')) | ||
| match = next((entry for entry in exceptions if entry['rule'] == item['reason'].lower() | ||
| and all(_matches(context.get(key, '') or '', [value]) if key == 'file' | ||
| else context.get(key) == value |
There was a problem hiding this comment.
When an INCONSISTENT_ARXML_ACCESS_MODE finding is waived using the documented file scope, the exception can never match: that finding stores its affected paths in the files mapping, while this code derives context['file'] only from call.file, arxml_file, or file. For example, an exception scoped to either of two conflicting ARXML files remains unapplied and the check still exits 1. Match the file pattern against the keys of the finding's files mapping as well.
Useful? React with 👍 / 👎.
longvo92
changed the title
What
Add
--check-current PATHfor folder/ZIP delivery checks without a baseline, diff or HTML. Preserve existing comparison flags and YAML configuration; comparisons default tostandard, while CURRENT-only defaults todeliveryand gates unchecked items.Fix consistency checks that could pass without ARXML, mix identically named runnables across SWCs, ignore explicit runnable symbols, or let one runnable hide another's orphan access. Retain full AUTOSAR paths/references, expose unsupported APIs and unresolved ownership, and support documented helper mappings and scoped exceptions through optional JSON configuration.
Print the tool version before CLI comparisons and CURRENT-only checks; preserve existing --version and --help output and exit codes.
Remove CLAUDE.md and point existing documentation comments to AGENTS.md as the sole repository instruction file. This follow-up changes documentation only; diff and reference checks passed.
Why
Pre-delivery validation needs a clear distinction between a complete policy pass, failed rules and incomplete coverage. Missing required input now always exits 2;
--exit-zerocannot suppress consistency failures. Unchanged-peer regeneration messages now ask for dependency review without claiming generation history from file identity.CURRENT JSON/SARIF finding exports remain P2 TODO in
docs/todo.mdanddocs/vi/todo.md. Existing comparison exports keep their schema; the new CURRENT-only mode rejects these flags until its exports are implemented. English/Vietnamese usage and architecture docs are updated.Viewer installs, builds and CI exclude PySide6 6.12.0: CI hit a native refcount crash in Qt highlighting on Python 3.11, and an isolated unchanged origin/main snapshot also crashed during process teardown with that version. PySide6 6.11.2 passed the full updated suite and exited normally. No CLI dependency was added.
Validation
Version header follow-up (a5753fb): 859 tests, Ruff, diff checks and CLI smoke passed for HTML, terminal-only, ARXML-only, CURRENT missing-input, --version and --help.
All six PR CI checks passed on commit c089395: lint, zipapp, and Windows/Linux with Python 3.8/3.11.
859 unit tests passed locally on Windows / Python 3.14.5 and Python 3.11.15 with PySide6 6.11.2, including Qt tests and 25 new delivery regressions. Both processes exited 0.
Ruff, Mypy and diff checks passed.
Legacy CLI HTML smoke produced a nonempty report with expected exit 1.
Zipapp built with
build.ps1 -PyzOnly; legacy comparison, CURRENT pass and incomplete/exit-zero cases passed.Qt viewer executed offscreen on the demo pair and its rendered advisory text was inspected.
Documented JSON examples, local documentation links and heading uniqueness checked.
Validation uses synthetic fixtures, not proprietary delivery code. The checker does not preprocess C or validate the full AUTOSAR schema; supported API coverage and exceptions are documented.
Action needed
Release v1.19.0 is authorized: merge after CI passes, then run release.yml on main with version=1.19.0 and publish=true. Version and dated changelog pass packaging/release_check.py.