Honor an optional submodule ref when fetching a customization submodule#99
Open
bjorkert wants to merge 2 commits into
Open
Honor an optional submodule ref when fetching a customization submodule#99bjorkert wants to merge 2 commits into
bjorkert wants to merge 2 commits into
Conversation
fetch_customization_submodule did a plain git clone of the default branch. If the .gitmodules entry a customization adds includes a 'branch' value, check it out after cloning (branch, tag, or SHA). Lets a customization pin a specific submodule version -- e.g. keep dev/main xdrip_cgm on the current plugin SHA while a next-dev variant points at a ported ref. No-op when unset (backward compatible).
This was referenced Jul 13, 2026
The previous commit edited the generated CustomizationSelect.sh directly; move the change into its source (inline_functions/patch_functions.sh, inlined via src/CustomizationSelect.sh) so it survives ./build.sh. Regenerated output is identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetch_customization_submodulecurrently does a plaingit cloneof the submodule's default branch. This adds: if the.gitmodulesentry a customization added includes abranchvalue, check it out after cloning — works for a branch, tag, or SHA.This lets a customization pin a specific plugin version. Concretely, it enables keeping the current
xdrip_cgmon the plugin's current SHA for dev/main, while a next-dev variant points at a different (ported) ref of a fork.Backward-compatible: no-op when no
branchis set, so existing customizations are unchanged.