Repository navigation
test(unity): space out player file revisions by one second - #491
Merged
Merged
Conversation
Revision timestamps are stored with second granularity, so two revisions created within the same second share an identical created_at. When the backend orders revisions by created_at the sort is a tie and the relative order of those revisions is undefined, which makes the revision ordering assertions flaky. Wait one second between the operations that create revisions so each revision gets a distinct timestamp. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kirre-bylund
force-pushed
the
ci/player-files-revision-ordering
branch
from
September 30, 2026 11:30
26b8863 to
e7b7584
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted test waits address the reported flakiness without changing SDK behavior.
Review effort: Balanced
Findings: None
What changed in this PR
This PR makes player-file revision tests more reliable by separating revision creation times so the backend can order them consistently.
Changes:
- Adds a one-second wait between revision-creating operations in five PlayMode tests.
| File | Description |
|---|---|
Tests/LootLockerTests/PlayMode/PlayerFilesTest.cs |
Spaces out revisions to avoid timestamp ties in ordering assertions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revision timestamps are stored with second granularity, so two revisions created within the same second share an identical created_at. When the backend orders revisions by created_at the sort is a tie and the relative order of those revisions is undefined, which makes the revision ordering assertions flaky.
Wait one second between the operations that create revisions so each revision gets a distinct timestamp.