Support capture display selection - #35
Open
RayZhao1998 wants to merge 1 commit into
Open
Conversation
Model: gpt-5.6-sol Harness: codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#34
Summary
Scope
This PR supports selecting one display for capture. Simultaneous capture of multiple displays remains out of scope.
An empty display UUID means “follow the current macOS main display,” preserving existing behavior and compatibility with older settings files.
Verification
make testswift test --filter DaemonWireTests— 64 tests passedswift test --filter SettingsDisplayPickerTests— passedmake snapshots— 30 snapshots generated and visually inspectedgit diff --checkpassedThe signed local launch required a machine-specific signing identity workaround that is intentionally excluded from this PR.
Risk
Risk: middle
The change crosses the Settings UI, versioned daemon protocol, persisted settings, live capture restart, and ScreenCaptureKit display resolution.
The fallback path preserves capture when a previously selected display is disconnected.
Confidence
High confidence in the protocol shape, persistence, picker layout, and single-display selection flow based on unit, wire, snapshot, and local runtime verification.
Not yet exhaustively verified across display hot-plugging or every rotated, scaled, and HDR multi-display topology.