bound composite left and top to coordinate limit#4564
Merged
Conversation
Owner
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Composite offsets truncate to 32-bit in native
The per-overlay
leftandtopare validated withis.integeronly, so any safe integer up to 2^53 is accepted, butAttrAsInt32narrows them before they reach thevips_compositeposition arrays. An offset such asleft: 4294967301silently becomes5, placing the overlay somewhere other than requested, while2147483648wraps negative and the overlay is dropped off-canvas with no error.Bounded both to -100000000..100000000, the same coordinate limit the sibling
extract/create/rawoptions already use. Negative offsets stay valid, so partly off-edge overlays are unaffected; only values that would truncate are now rejected up front. Regression cases added alongside the existing invalidleft/toptests.