Fix infinite loop in parse_md and optimize CJK processing#2
Open
patdelphi wants to merge 1 commit intolovstudio:mainfrom
Open
Fix infinite loop in parse_md and optimize CJK processing#2patdelphi wants to merge 1 commit intolovstudio:mainfrom
patdelphi wants to merge 1 commit intolovstudio:mainfrom
Conversation
The paragraph parsing loop in parse_md() would hang indefinitely on lines that matched no pattern (e.g. certain metadata lines), because `i` was never incremented when `plines` was empty. This caused timeouts on any document with such lines — including the 200KB xin1.md test file. Also optimizes CJK detection (bisect), font wrapping (batch processing), inline markdown (pre-compiled regex + caching), and text measurement (shared _split_cjk_segs helper). Result: xin1.md converts in 1.5s instead of timing out. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_md()that caused timeouts on large documents — when a line matched no pattern andplineswas empty,iwas never incrementedbisectbinary search), font wrapping (batch processing), inline markdown (pre-compiled regex + caching), and text measurement (shared_split_cjk_segshelper)Test plan
🤖 Generated with Claude Code