ci(windows): migrate integration matrix from windows-2022 to windows-2025 - #395
Merged
Conversation
Split the WSL package install out of Vampire/setup-wsl's one-shot additional-packages so we can retry apt-get update/install (with Acquire::Retries) instead of failing the whole job on a transient archive.ubuntu.com mirror hash mismatch. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add a single windows-2025 job (continue-on-error) alongside the existing windows-2022 matrix to empirically validate WinRM/WSL/SQL Server install compatibility before deciding on a full migration. Temporary, to be removed once results are gathered. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Both windows-2022 and windows-2025 runner images ship MongoDB Stopped/Disabled by default now, so this defensive step is dead weight. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…2025 Early results from a windows-2025 probe job (WinRM, WSL1, mssqlsuite SQL Server install) show no compatibility issues, so switch the whole matrix over instead of running both. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The full eight-leg Windows 2025 integration matrix is still running and must complete successfully before merge.
Pull request overview
Migrates Windows integration CI to windows-2025 and improves setup reliability.
Changes:
- Updates the integration matrix and job names to Windows 2025.
- Adds retry handling for WSL package installation.
- Removes obsolete MongoDB service handling.
File summaries
| File | Description |
|---|---|
.github/workflows/ansible-test-windows.yml |
Updates the runner matrix and WSL setup steps. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ConfigureRemotingForAnsible.ps1 (run immediately before) already starts the WinRM service, sets it to auto-start, creates the HTTP/HTTPS listeners, opens the required firewall rules, and self-tests both transports. The separate 'winrm quickconfig -force' step ran against an already-fully-configured WinRM and did nothing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…entation The script moved from ansible/ansible to ansible/ansible-documentation. Pin to a current commit there and link the devel URL for future updates. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the Windows integration test matrix in
ansible-test-windows.ymlfromwindows-2022towindows-2025, and cleans up two adjacent CI reliability issues found along the way:windows-2022→windows-2025: newer runner image, same OS family. Validated with a probe job (singlewindows-2025leg run alongside the existing matrix) before switching the whole matrix over — no WinRM, WSL1, or SQL Server install compatibility issues observed.apt-get:Vampire/setup-wsl'sadditional-packagesdid a one-shotapt-get update/installthat could fail on a transient Ubuntu archive mirror hash mismatch. Split it into its own step withAcquire::Retriesand a 3-attempt retry loop, matching the existing retry pattern already used formssqlsuite/ansible-galaxyin this workflow.windows-2022andwindows-2025runner images ship MongoDBStopped/Disabledby default now, so the step was dead weight.Why
windows-11-armwas considered for faster Windows CI but isn't viable: WSL2/nested virtualization isn't supported on ARM runners, and SQL Server has no ARM64 build.windows-2025is a safer, low-risk incremental update instead.mssqlsuite/dbatools capabilities aren't gated by the runner OS, so this change is scoped to just the OS bump plus the two unrelated reliability fixes above.Validation
zizmorand YAML parsing pass locally.windows-2025probe job (matrixinclude) ran alongside the existingwindows-2022matrix without early failure before the full matrix switch.windows-2025— please confirm all jobs pass before merging.Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com