chore: release 3.1.0 - #399
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several examples remain invalid or misleading, including malformed YAML, incorrect schedule formats, and an invalid listener subnet.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Standardizes SQL Server module examples for consistency and correctness.
Changes:
- Normalizes example names, hosts, databases, and identifiers.
- Corrects module references and adds required parameters.
- Replaces literal credentials with Ansible Vault variables.
File summaries
| File | Description |
|---|---|
plugins/modules/user.py |
Corrects user module examples. |
plugins/modules/user_role.py |
Standardizes database-role examples. |
plugins/modules/traceflag.py |
Clarifies trace-flag examples. |
plugins/modules/tcp_port.py |
Standardizes port examples. |
plugins/modules/spn.py |
Simplifies SPN examples. |
plugins/modules/sp_whoisactive.py |
Standardizes installation example. |
plugins/modules/sp_configure.py |
Clarifies configuration example. |
plugins/modules/sa.py |
Standardizes sa-login examples. |
plugins/modules/rg_workload_group.py |
Updates Resource Governor workflow. |
plugins/modules/rg_resource_pool.py |
Updates resource-pool examples. |
plugins/modules/restore.py |
Adds required backup paths. |
plugins/modules/resource_governor.py |
Standardizes enablement example. |
plugins/modules/nonquery.py |
Updates DML example. |
plugins/modules/memory.py |
Clarifies memory examples. |
plugins/modules/maintenance_solution.py |
Corrects module and options. |
plugins/modules/login.py |
Uses a Vault password variable. |
plugins/modules/login_role.py |
Corrects login terminology. |
plugins/modules/instance_info.py |
Standardizes instance example. |
plugins/modules/install_script.py |
Clarifies migration example. |
plugins/modules/hadr.py |
Clarifies HADR restart behavior. |
plugins/modules/first_responder_kit.py |
Standardizes installation example. |
plugins/modules/dba_multitool.py |
Standardizes installation values. |
plugins/modules/database.py |
Standardizes database examples. |
plugins/modules/credential.py |
Adds names and Vault credentials. |
plugins/modules/backup.py |
Standardizes backup examples. |
plugins/modules/availability_group.py |
Standardizes availability-group example. |
plugins/modules/agent_job.py |
Standardizes Agent job example. |
plugins/modules/agent_job_step.py |
Updates job-step examples. |
plugins/modules/agent_job_schedule.py |
Adds required job and schedule values. |
plugins/modules/agent_job_category.py |
Standardizes category example. |
plugins/modules/ag_replica.py |
Standardizes replica workflow. |
plugins/modules/ag_listener.py |
Updates listener workflow. |
changelogs/fragments/399-documentation-examples.yml |
Records documentation updates. |
Review details
- Files reviewed: 33/33 changed files
- Comments generated: 5
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: John McCall <john@overturemaps.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Standardizes the names and formatting used across module documentation examples, and corrects examples that referenced unsupported parameters, omitted required options, or called the wrong module. Credential examples now use Ansible Vault variables instead of literal password placeholders.
Bumps
galaxy.ymlto3.1.0and runsantsibull-changelog releaseto consume the pending fragments (381,382,399) intochangelogs/changelog.yamlandCHANGELOG.rst.How Has This Been Tested?
Parsed every module example as YAML, checked that referenced modules and required options resolve, and ran
antsibull-changelog lint(via WSL, sinceansible-docrequires POSIX blocking-IO support Windows doesn't provide) both before and after the release.Types of changes
Checklist:
version_addedproperty.