Add shutdown operation for Stream sockets#67
Open
sternenseemann wants to merge 1 commit intolpeterse:masterfrom
Open
Add shutdown operation for Stream sockets#67sternenseemann wants to merge 1 commit intolpeterse:masterfrom
sternenseemann wants to merge 1 commit intolpeterse:masterfrom
Conversation
shutdown is useful since it can be used to send a TCP FIN which in turn requires the other side to close the connection as well making it possible to gracefully terminate a TCP connection. Windows is untested as of now, but CI should take care of that. Test cases have been added, unfortunately, the exceptions don't seem to line up across platforms, but that doesn't seem to be a design goal of this library. Currently the action is tied to Stream, rather than TCP (which doesn't make a difference currently), as the action is not necessarily TCP specific, but I'm not 100% certain.
sternenseemann
force-pushed
the
shutdown
branch
from
e853a7e to
e9863ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shutdown is useful since it can be used to send a TCP FIN which in turn
requires the other side to close the connection as well making it
possible to gracefully terminate a TCP connection.
Windows is untested as of now,
but CI should take care of that.Test cases have been added, unfortunately, the exceptions don't seem to
line up across platforms, but that doesn't seem to be a design goal of
this library.
Currently the action is tied to Stream, rather than TCP (which doesn't
make a difference currently), as the action is not necessarily TCP
specific, but I'm not 100% certain.