Skip to content

DM-55678: Remove env vars with dataset IDs for Load SSO #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JeremyMcCormick wants to merge 1 commit into from
+0 −14
Closed

DM-55678: Remove env vars with dataset IDs for Load SSO #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions environment/deployments/ppdb/services/load-sso.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,6 @@ resource "google_cloudfunctions2_function" "load_sso" {
SERVICE_ACCOUNT_EMAIL = google_service_account.dataflow_load_sso.email
TEMP_LOCATION = var.load_sso_cloud_run_temp_location
LOG_EXECUTION_ID = var.load_sso_cloud_run_log_execution_id
STAGING_DATASET_ID = var.load_sso_staging_dataset_id
INTERNAL_DATASET_ID = var.load_sso_internal_dataset_id
}
}

Expand Down
12 changes: 0 additions & 12 deletions environment/deployments/ppdb/services/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,18 +351,6 @@ variable "load_sso_cloud_run_temp_location" {
type = string
}

variable "load_sso_staging_dataset_id" {
description = "BigQuery dataset ID for staging tables written before the swap into the internal dataset"
default = "ppdb_staging"
type = string
}

variable "load_sso_internal_dataset_id" {
description = "BigQuery dataset ID for the internal tables that staging tables are swapped into"
default = "ppdb_internal"
type = string
}

variable "load_sso_runtime" {
description = "Runtime for Cloud Run Functions"
type = string
Expand Down
Loading