Skip to content

Calibration refactoring#107

Merged
lucabaldini merged 7 commits intomainfrom
calibration_refactoring
Apr 23, 2026
Merged

Calibration refactoring#107
lucabaldini merged 7 commits intomainfrom
calibration_refactoring

Conversation

@augustocattafesta
Copy link
Copy Markdown
Collaborator

Noise and gain calibration divided in two different commands and added a new command to calibrate the eta function from CLI.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors calibration workflows by splitting gain and noise calibration into separate CLI subcommands and adding a new CLI entry point to calibrate the eta function (previously provided via a standalone script).

Changes:

  • Added calibrate eta|noise|gain subcommands and corresponding pipeline/task entry points.
  • Moved eta calibration logic into hexsample.tasks and removed the standalone scripts/calibration.py.
  • Simplified hexsample.calibration imports and removed the old calibration_data() helper.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
src/hexsample/tasks.py Introduces open_file()/create_readout() helpers and adds calibrate_eta, calibrate_noise, calibrate_gain tasks.
src/hexsample/pipeline.py Replaces the single calibrate() entry point with separate calibrate_eta/noise/gain() pipeline functions.
src/hexsample/cli.py Adds nested calibrate subcommands and new CLI options (--num_bins, --enc), removes old calibration option group.
src/hexsample/calibration.py Removes unused imports and deletes calibration_data() helper; minor adjustment in profile().
scripts/calibration.py Deletes the legacy standalone eta calibration script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/hexsample/tasks.py
Comment thread src/hexsample/tasks.py
Comment thread src/hexsample/pipeline.py Outdated
Comment thread src/hexsample/cli.py Outdated
Comment thread src/hexsample/cli.py
Comment thread src/hexsample/tasks.py Outdated
Comment thread src/hexsample/tasks.py Outdated
Comment thread src/hexsample/tasks.py
@lucabaldini lucabaldini merged commit cd7bfb3 into main Apr 23, 2026
2 checks passed
@lucabaldini lucabaldini deleted the calibration_refactoring branch April 23, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants