Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors calibration workflows by splitting gain and noise calibration into separate CLI subcommands and adding a new CLI entry point to calibrate the eta function (previously provided via a standalone script).
Changes:
- Added
calibrate eta|noise|gainsubcommands and corresponding pipeline/task entry points. - Moved eta calibration logic into
hexsample.tasksand removed the standalonescripts/calibration.py. - Simplified
hexsample.calibrationimports and removed the oldcalibration_data()helper.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
src/hexsample/tasks.py |
Introduces open_file()/create_readout() helpers and adds calibrate_eta, calibrate_noise, calibrate_gain tasks. |
src/hexsample/pipeline.py |
Replaces the single calibrate() entry point with separate calibrate_eta/noise/gain() pipeline functions. |
src/hexsample/cli.py |
Adds nested calibrate subcommands and new CLI options (--num_bins, --enc), removes old calibration option group. |
src/hexsample/calibration.py |
Removes unused imports and deletes calibration_data() helper; minor adjustment in profile(). |
scripts/calibration.py |
Deletes the legacy standalone eta calibration script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noise and gain calibration divided in two different commands and added a new command to calibrate the eta function from CLI.