fix: Conditionally download shellcheck#100
Open
airtonix wants to merge 1 commit intoludeeus:masterfrom
Open
Conversation
airtonix
commented
Dec 12, 2023
airtonix
commented
- if shellcheck doesn't exist, downloads it. optionally to a version specified.
- if it exists and no version is specified, use that
- if it exists but a version specified, and it matches use that
- otherwise fail loudly
- if shellcheck doesn't exist, downloads it. optionally to a version specified. - if it exists and no version is specified, use that - if it exists but a version specified, and it matches use that - otherwise fail loudly
ludeeus
reviewed
Aug 26, 2024
| osvariant="darwin" | ||
| else | ||
| osvariant="linux" | ||
| # check if shellcheck already installed |
Owner
There was a problem hiding this comment.
Make this check optional with a input variable that defaults to false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.