fix: add post-migration repair step to heal missing appointment columns#69
Open
fix: add post-migration repair step to heal missing appointment columns#69
Conversation
Some Nextcloud installs (#68) record migration 12 in oc_migrations without applying its DDL, leaving att_appointments without closed_at / response_deadline and breaking AutoCloseJob. Re-apply those columns and indexes idempotently from a post-migration repair step so app enable / occ upgrade self-heals affected installs.
|
Thanks for the quick fix and the clean self-healing approach really appreciated! 👍👌 |
Probe the columns with a cheap SELECT … LIMIT 0 first; only fall back to createSchema()/migrateToSchema() when the probe fails. Saves a full-database schema introspection on every occ upgrade in the steady state, where the columns are already present. Also use OCP\DB\Types::DATETIME for consistency and clean up the test factory's bool-soup signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Nextcloud installs (#68) record migration 12 in oc_migrations
without applying its DDL, leaving att_appointments without closed_at /
response_deadline and breaking AutoCloseJob.
Re-apply those columns and indexes idempotently from a post-migration
repair step so app enable / occ upgrade self-heals affected installs.