fix: preserve valid make-child targets during drop redirection#186
Open
tensor2077 wants to merge 2 commits intolukasbach:mainfrom
Open
fix: preserve valid make-child targets during drop redirection#186tensor2077 wants to merge 2 commits intolukasbach:mainfrom
tensor2077 wants to merge 2 commits intolukasbach:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 1937844 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #0
@lukasbach
with.bug.mov
fixed.mov
getDragTarget redirects away from a valid MakeChild target when the parent target is invalid and canReorder is false
getDragTargetseems to discard a validMakeChildtarget in this case:MakeChildtargetcanReorderisfalseExpected: the current item should remain the final drop target.
Actual:
getDragTargetrecurses to the parent first, so the valid child target is lost and the drop never stabilizes on the current item.The problematic branch seems to be the
!canReorder && parent && !canBecomeSiblingrecursion running before thePlacementType.MakeChildreturn.